Remove setpoints and wind condition specifics from calculate_XX_plane methods #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
added
enhancement
…otor_diameters field on fmodel.
paulf81
reviewed
Apr 5, 2024
What's the cause of this being slower? |
@rafmudaf , well, I'm not sure that it's slower, but I changed from exporting the existing |
|
I've now gone ahead and made the commensurate changes to |
rafmudaf
reviewed
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various methods used for visualization on
FlorisModel(calculate_horizontal_plane(),calculate_cross_plane(), andcalculate_y_plane()) still acceptedyaw_anglesas an input, but not other control setpoints.If
yaw_angleswere passed, they were applied; and ifyaw_angleswere not passed, the stored yaw angles were used (which could lead to findex length clashes, if thefmodelhadn_findex> 1).Simply removing
yaw_anglesas an input and allowing those that had already beensetto be used could create a findex clash. Instead, I decided to:yaw_anglesas an inputwd,ws, andtias inputsfindexthey would like to visualizeset_for_viz; deepcopies offmodelto get around issue with setpoints not being stored on the dictionary (which has come up a couple of times now---we may need a better fix for this issue).The result works, but may be somewhat slower than before. However, I'm not sure this is the path we'd like to go down, so I'd like some feedback here. If we are OK with this, I can also make some changes to simplify
calculate_horizontal_plane_with_turbines()on flow_visualization.py. Once those changes are in, thecheck_wind_condition_for_viz()method onFlorisModelcan likely be removed. For now, I've simply removed the erroneous type hints oncheck_wind_condition_for_viz().I'll also add some tests for all of this if we do want to go with this approach.